simplify asDouble and avoid the need for WITH_LIBTMB with by using#311
Open
boennecd wants to merge 1 commit intokaskr:masterfrom
Open
simplify asDouble and avoid the need for WITH_LIBTMB with by using#311boennecd wants to merge 1 commit intokaskr:masterfrom
asDouble and avoid the need for WITH_LIBTMB with by using#311boennecd wants to merge 1 commit intokaskr:masterfrom
Conversation
asDouble and avoid the need for WITH_LIBTMB with by using
Owner
|
Thanks for the PR - your changes make sense. In case you make other changes I would kindly ask to split in many small commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
inlinechange loop order in
asSEXPandasMatrix(R matrices are in column major order)fix #309
Notice that there is still a
valuefunction here:adcomp/TMB/inst/include/tmb_core.hpp
Lines 803 to 818 in 52002f8
which can be changed to