DNM: feat(cli): specify ignore rules in a file at snapshot time#567
Draft
julio-lopez wants to merge 6 commits into
Draft
DNM: feat(cli): specify ignore rules in a file at snapshot time#567julio-lopez wants to merge 6 commits into
julio-lopez wants to merge 6 commits into
Conversation
Add a flag to the `snapshot create` command, which allows specifying additional ignore rules stored in files external to the back up source directory. This means that the file containing ignore rules does not need to be within the directory being backed up, which allows specifying additional ignore rules without modifying the directory being backed up, nor requiring creating or modifying policies on the fly. - Adds a new flag to the kopia snapshot create command which accepts the absolute path of a file containing ignore rules which will be applied towards the source being backed up. - The new ignore file/rules will be considered in addition to the already configured ignore rules and files as part of the policy hierarchy. - Testing: unit tests and end-to-end tests included.
- add new field to ignoreContext to propagate external ignore rules - cleanup: reuse ignorefs ignorefile parsing - improving naming convention to make design decision clear
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
julio-lopez
force-pushed
the
kasten
branch
2 times, most recently
from
a3807d5 to
118ff3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.