chore(html): Fix HTML doc examples to use TNativeXml.Create(nil)#10
Open
dddwwwbbb wants to merge 5 commits intokattunga:masterfrom
Open
chore(html): Fix HTML doc examples to use TNativeXml.Create(nil)#10dddwwwbbb wants to merge 5 commits intokattunga:masterfrom
dddwwwbbb wants to merge 5 commits intokattunga:masterfrom
Conversation
Create to Create(nil) per NativeXml.pas constructor Create(AOwner: TComponent)
Create to Create(nil) per NativeXml.pas constructor Create(AOwner: TComponent)
Create to Create(nil) per NativeXml.pas constructor Create(AOwner: TComponent)
Create to Create(nil) per NativeXml.pas constructor Create(AOwner: TComponent)
Default encoding="utf-8" but example .xml file shows encoding="windows-1252". Set Charset accordingly, analogous to ExternalEncoding := seAnsi; ExternalCodepage := 1252;.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated several .html documentation files to fix code examples that incorrectly called TNativeXml.Create without a parameter which would cause error E2035: Not enough actual parameters on the Create. The NativeXml.pas constructor Create(AOwner: TComponent) requires one so nil was passed. Note that Create suppresses the first line header (version, encoding) of a saved xml file versus CreateName('Root'). Fix 000063.html code to match file.