fix(cmd): add missing defer db.Close(), fix uncheked errors - #74
Merged
Conversation
Contributor
Author
|
I noticed that error checking isn't implemented everywhere for example, here
Run: func(cmd *cobra.Command, args []string) {
os.MkdirAll(".eko/snapshots", 0755)
database := db.InitDB()
defer database.Close()
database.Exec(`
CREATE TABLE IF NOT EXISTS snapshots (
id TEXT PRIMARY KEY,
message TEXT,
path TEXT,
created_at DATETIME DEFAULT CURRENT_TIMESTAMP
)
`)
fmt.Println("Eko initialized.")
// Check if a .git directory exists
if info, err := os.Stat(".git"); err == nil && info.IsDir() {
fmt.Println("Tip: A Git repository was detected. Eko runs independently of Git but automatically ignores the .git directory.")
}
},So, I can replace Run with RunE and return an error here and in other places in the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #73