Skip to content

mypy fixes: remove warn_no_return #451

Merged
kayjan merged 4 commits into
masterfrom
feat/enhance-mypy
May 5, 2026
Merged

mypy fixes: remove warn_no_return #451
kayjan merged 4 commits into
masterfrom
feat/enhance-mypy

Conversation

@kayjan
Copy link
Copy Markdown
Owner

@kayjan kayjan commented May 5, 2026

Description

Testing

Additional notes

Checklist

I have read through the contributing guidelines and ensured that

  • I have added a descriptive title for this pull request.
  • I have followed the convention and standards, and my code is checked for style and correctness.
  • I have added test cases, and unit tests pass with 100% code coverage.
  • I have updated the documentation and code docstrings.

Checklist (for reviewer)

  • I have added label (breaking / enhancement / bug / documentation) to this pull request, if applicable.
  • I will ensure this change is captured in the CHANGELOG.md file.

@kayjan kayjan changed the title mypy fixes: remove ignore warn_no_return mypy fixes: remove warn_no_return May 5, 2026
@kayjan kayjan added the documentation Improvements or additions to documentation label May 5, 2026
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: 02be03e Previous: e82318e Ratio
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 16737.143990460147 iter/sec (stddev: 0.000007478290606662881) 19023.05213448723 iter/sec (stddev: 5.320271429759399e-7) 1.14
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 412.0728867104186 iter/sec (stddev: 0.000004902583445930372) 462.8762272441753 iter/sec (stddev: 0.000018099741566939336) 1.12
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 14.183165591575122 iter/sec (stddev: 0.00013987258025386512) 14.569176693501037 iter/sec (stddev: 0.0007298226572423845) 1.03
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 83.8518708570329 iter/sec (stddev: 0.00009503691915703288) 90.16361811452863 iter/sec (stddev: 0.00034533016299322566) 1.08
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions 39117.43248809273 iter/sec (stddev: 0.000004580708438628538) 43671.26889436422 iter/sec (stddev: 7.360274483910662e-7) 1.12
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions_config 29325.857194936227 iter/sec (stddev: 0.000017808060020436432) 33929.24395502846 iter/sec (stddev: 0.000014015563510446425) 1.16
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions 164.2097710199851 iter/sec (stddev: 0.008120438458198789) 275.6214761277847 iter/sec (stddev: 0.004709516141837178) 1.68
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions_config 3030.573026802568 iter/sec (stddev: 5.802518239162393e-7) 3281.118703996261 iter/sec (stddev: 0.0000051276555336610664) 1.08
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions 254.95511642651968 iter/sec (stddev: 0.000012370550294241271) 273.82189566948034 iter/sec (stddev: 0.000024435913301592295) 1.07
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions_config 244.2062285946422 iter/sec (stddev: 0.0002072969088970219) 264.09437338484304 iter/sec (stddev: 0.00017955746342464165) 1.08
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions 189.43271210834558 iter/sec (stddev: 0.00023434989510670543) 214.9882798601459 iter/sec (stddev: 0.00022127810701656704) 1.13
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions_config 91.56062801435318 iter/sec (stddev: 0.008509924894091535) 134.54711334012399 iter/sec (stddev: 0.004249351979001657) 1.47

This comment was automatically generated by workflow using github-action-benchmark.

@kayjan kayjan enabled auto-merge (squash) May 5, 2026 18:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Code Coverage

Package Line Rate Branch Rate Complexity Health
bigtree 100% 100% 0
bigtree.binarytree 100% 100% 0
bigtree.dag 100% 100% 0
bigtree.node 100% 100% 0
bigtree.tree 100% 100% 0
bigtree.tree.construct 100% 100% 0
bigtree.tree.export 100% 100% 0
bigtree.utils 100% 100% 0
Summary 100% (3241 / 3241) 100% (1164 / 1164) 0

@kayjan kayjan merged commit 91063ab into master May 5, 2026
5 checks passed
@kayjan kayjan deleted the feat/enhance-mypy branch May 5, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant