[TASK] enable generation of sourcemaps#20
[TASK] enable generation of sourcemaps#20pniederlag wants to merge 1 commit intokaystrobach:masterfrom
Conversation
| try { | ||
| $this->parser->setVariables($this->overrides); | ||
| $this->parser->setImportPaths(array(dirname($inputFilename), dirname($preparedFilename))); | ||
| if (ApplicationContext::isDevelopmentModeActive() || $this->config['enableDebugMode'] === '1') { |
There was a problem hiding this comment.
from my POV i would rather say, dev context AND enableDebugMode, would also change the less parser accordingly - respecting the context feels more natural here.
https://github.com/kaystrobach/TYPO3.dyncss_less/blob/master/Classes/Parser/LessParser.php#L104
There was a problem hiding this comment.
nope, please not. ;)
There are times when you need to debug "ad hoc", and I hate it when I have to login to the BE in order to adapt a setting. As EM config is serialized array it's really tough to change from CLI (Not sure wether typo3_console supports it?).
Also it is really tough to keep ext_conf_template.txt settings different per environment, when you have everything in SCM and have deployments with adapted settings (.env, HostConfiguration) per site/installation.
So I am in big favor of having a simple mechanism to toggle this feature, without EM settings ;)
There was a problem hiding this comment.
ok, then i would opt for deprecating the debugMode and simply switch to contexts ...
There was a problem hiding this comment.
What's wrong with having two different options?
In general TYPO3 Context will take care of properly enabling/disabling the feature
If you want to use sourcemaps, but for some reason(production?) don't want to set development context, well then enableDebugMode.
I don't see the cost involved of keeping enableDebugMode while prefering Context.
2 participants
generate and add css sourcemaps for any TYPO3 Development context or by enabling debugMode in extension configuration of EXT:dyncss