Skip to content

Add option for sending emails to new participants only - #146

Open
Jcen902 wants to merge 1 commit into
kblincoe:masterfrom
nateeo:Alternative-options-for-sending-emails
Open

Add option for sending emails to new participants only#146
Jcen902 wants to merge 1 commit into
kblincoe:masterfrom
nateeo:Alternative-options-for-sending-emails

Conversation

@Jcen902

@Jcen902 Jcen902 commented Mar 27, 2018

Copy link
Copy Markdown
Contributor

PR for #35 ,Add option for sending emails to new participants only, the change are:

  1. Add a new button in study-detail page(and the associate .html and .ts).
  2. A new table is create to store the list of email address that the study have sent invitation email to.
  3. Study class have a new Set for saving the list of email address that the study have sent invitation email to. This Set is mapped by @ElementCollection into the table in 2.
  4. StudyServce class's sendInvitationEmail() take the necessary information from study only instead of receiving the whole Study object.
  5. StudyResource has two @put resource to handle send emails to all participants and send emails to new participants instead of just one.
  6. A new @put for updating the list of email address that the study have sent to and for updating the table I mention in 2.
  7. In study-component page, the "Send Invitation" button is link to the "View" button, which is, they are doing the same thing now as "Send Invitation" should provide the options for sending to all participants or to new participants only.

@Jcen902

Jcen902 commented Mar 27, 2018

Copy link
Copy Markdown
Contributor Author

@nateeo @jsoulsby Here you are, just base on my old code with some small fix

@nateeo nateeo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jsoulsby jsoulsby left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall, nice work on the modal 👍

* POST /studies/send : send the study.
* POST /studies/sendToAll : send the study to all participants
*
* @param study the study to send

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be "send the study to all participants"?

@Jcen902

Jcen902 commented Mar 27, 2018

Copy link
Copy Markdown
Contributor Author

@jsoulsby Fixed

@Jcen902

Jcen902 commented Mar 27, 2018

Copy link
Copy Markdown
Contributor Author

@softeng-701 Merge please.

@Jcen902

Jcen902 commented Mar 28, 2018

Copy link
Copy Markdown
Contributor Author

@softeng-701 Squash is done. @nateeo there because he teach me about squashing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants