Skip to content

Comments

Suggestions to improve download error checking ... not PR#4

Open
jimrothstein wants to merge 1 commit intokbmorales:masterfrom
jimrothstein:jim_demo
Open

Suggestions to improve download error checking ... not PR#4
jimrothstein wants to merge 1 commit intokbmorales:masterfrom
jimrothstein:jim_demo

Conversation

@jimrothstein
Copy link

@jimrothstein jimrothstein commented Sep 21, 2020

Beginning with line "SUGGESTIONS", could you take a look at this alternative code to download PPP files:

  • Use httr::GET with stop_for_status() check
  • Use testthat:expect_:identical() to check content is indeed of form .zip

Just your comments would be great.
If you like it, I can do real PR.

@kbmorales

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant