support for multi factor tokens on action invocations#253
Open
andponlin wants to merge 2 commits intokbr:developmentfrom
Open
support for multi factor tokens on action invocations#253andponlin wants to merge 2 commits intokbr:developmentfrom
andponlin wants to merge 2 commits intokbr:developmentfrom
Conversation
Author
|
Hi; is it likely this PR will end up getting merged into the library? 🤔 |
Owner
|
Short answer: yes. I'm far behind schedule and will come to this back in the next. Sorry for the delay so far. |
Author
|
Thanks Klaus; no problem and thank you! |
Owner
|
Hi Andrew, you may have mentioned that there is a bugfix-release 1.15.1 without merging this pull-request. I plan to do this at the next major release - may be that there will be merge conflicts then. We will see. However your PR will get added. |
Author
|
Hello Klaus; thank you for letting know -- appreciated. Do you feel the new major version will be in the next month or so? |
Owner
|
Hard to say, but hope in the first quarter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some SOAP calls into the router require that a multi-factor token also be provided using a SOAP header. An example of such a header and documentation can be found here. As-built, the
fritzconnectionlibrary provides no means to supply this additional header and so there's no way to use these actions.This PR will introduce a means by which, on an action-call by action-call basis, these is a mechanism to supply the token and to consequently have the SOAP header added.