Skip to content

Refactor macOSUpgrade.sh#121

Merged
kenchan0130 merged 4 commits into
kc9wwh:masterfrom
kenchan0130:refactor-macosupgrade
Jul 1, 2019
Merged

Refactor macOSUpgrade.sh#121
kenchan0130 merged 4 commits into
kc9wwh:masterfrom
kenchan0130:refactor-macosupgrade

Conversation

@kenchan0130

@kenchan0130 kenchan0130 commented Jun 28, 2019

Copy link
Copy Markdown
Collaborator

* Readable comment with space
* Using array variable with startosinstall options
Comment thread macOSUpgrade.sh
Comment thread macOSUpgrade.sh
Comment thread macOSUpgrade.sh
Comment thread macOSUpgrade.sh

@taniguti taniguti left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional fix propose.

Comment thread macOSUpgrade.sh Outdated

@taniguti taniguti left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenchan0130
kenchan0130 merged commit b4f08a5 into kc9wwh:master Jul 1, 2019
@kenchan0130
kenchan0130 deleted the refactor-macosupgrade branch July 1, 2019 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants