Skip to content

fix: mixin/protocol schema suffix#149

Merged
Peefy merged 1 commit intokcl-lang:mainfrom
project0:fix/mixin_protocol_suffix
Mar 5, 2026
Merged

fix: mixin/protocol schema suffix#149
Peefy merged 1 commit intokcl-lang:mainfrom
project0:fix/mixin_protocol_suffix

Conversation

@project0
Copy link
Copy Markdown
Contributor

@project0 project0 commented Mar 5, 2026

fix feature and wrong behavior introduced by #146

  • fix CompareDir early-returning after first subdirectory, causing remaining files to be skipped in integration test comparison

  • fix Mixin/Protocol schema suffix protection applying to property field names instead of generated schema type names: remove suffix logic from kclName (which is shared between property and schema naming) and add a protectedSchemaName helper applied only at inline schema creation in buildProperties

  • add integration test case suffix_protected_mixin_protocol covering CRD properties whose names end with Mixin or Protocol

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

fix feature and wrong behavior introduced by kcl-lang#146

* fix Mixin/Protocol schema suffix protection applying to property field names instead of generated schema type names: remove suffix logic from kclName (which is shared between property and schema naming) and add a protectedSchemaName helper applied only at inline schema creation in buildProperties

* add integration test case suffix_protected_mixin_protocol covering CRD properties whose names end with Mixin or Protocol

* fix CompareDir early-returning after first subdirectory, causing remaining files to be skipped in integration test comparison

Signed-off-by: Richard Hillmann <richard@flowers-software.de>
@project0 project0 force-pushed the fix/mixin_protocol_suffix branch from b9b93ef to 316cf27 Compare March 5, 2026 21:58
@project0
Copy link
Copy Markdown
Contributor Author

project0 commented Mar 5, 2026

tests are failing because of some race conditions with not using proper atomic tmp files/folders. I tried fixing those, but it is a bigger task that justifies a extra PR. Nevertheless, the flaky tests are unrelated to the PR.

@Peefy Peefy merged commit bdd04af into kcl-lang:main Mar 5, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants