Merged
Conversation
fix feature and wrong behavior introduced by kcl-lang#146 * fix Mixin/Protocol schema suffix protection applying to property field names instead of generated schema type names: remove suffix logic from kclName (which is shared between property and schema naming) and add a protectedSchemaName helper applied only at inline schema creation in buildProperties * add integration test case suffix_protected_mixin_protocol covering CRD properties whose names end with Mixin or Protocol * fix CompareDir early-returning after first subdirectory, causing remaining files to be skipped in integration test comparison Signed-off-by: Richard Hillmann <richard@flowers-software.de>
b9b93ef to
316cf27
Compare
Contributor
Author
|
tests are failing because of some race conditions with not using proper atomic tmp files/folders. I tried fixing those, but it is a bigger task that justifies a extra PR. Nevertheless, the flaky tests are unrelated to the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix feature and wrong behavior introduced by #146
fix CompareDir early-returning after first subdirectory, causing remaining files to be skipped in integration test comparison
fix Mixin/Protocol schema suffix protection applying to property field names instead of generated schema type names: remove suffix logic from kclName (which is shared between property and schema naming) and add a protectedSchemaName helper applied only at inline schema creation in buildProperties
add integration test case suffix_protected_mixin_protocol covering CRD properties whose names end with Mixin or Protocol
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: