Skip to content

[DIFF] kcp-1.33.3#3514

Closed
ntnn wants to merge 18 commits intokcp-dev:mainfrom
ntnn:kcp-1.33.3-diff
Closed

[DIFF] kcp-1.33.3#3514
ntnn wants to merge 18 commits intokcp-dev:mainfrom
ntnn:kcp-1.33.3-diff

Conversation

@ntnn
Copy link
Copy Markdown
Member

@ntnn ntnn commented Aug 5, 2025

For #3511

ntnn added 18 commits August 5, 2025 16:13
@ntnn
Configure workflows to use go-version from go.mod
8112135 
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
Read any go version, not just 1.x
ecd3c55 
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
Handle *.yml files and no explicit versions in workflows
435b0bb 
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
Check all go.mod's go versions
b27fe7a 
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
Bump go version to 1.24.0
98280cf 
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
Explicitly ignore error instead of nolint:errcheck
0f9005a 
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
DefaultKubeEffectiveVersion moved compatibility
6683e83 
See kubernetes/kubernetes#129416

Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
Add PodTopologyLabels plugin
ff0b4a9 
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
Fix linter issue
f58ef1e 
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
Switch from gofuzz to randfill
ea77b44 
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
Pass context
03c9025 
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
Disable version emulation flags
ceaea97 
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
Add new KCP leak
756e5b2 
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
Update dependencies to kcp-1.33.3
7cf67e2 
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
Remove test failing due to list-via-watch removal
4d4673c 
Upstream disabled list-via-watch in kubernetes/kubernetes#131359

Reenabling would be possible through a feature gate but upstream doesn't
seem keen on continuing the feature.

Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
Fix sed call on MacOS
74facfc 
The sed call would always leave a "go.mod''" since the expansion was
quoting the quotes again.

Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
Download go modules before going into goreleaser
3a42462 
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
Restrict goreleaser run one build at a time
11bf8b8 
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@kcp-ci-bot kcp-ci-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2025
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Aug 5, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 5, 2025
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Aug 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Aug 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mjudeikis for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added area/cli Issues or PRs related to CLI changes do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 5, 2025
@ntnn ntnn mentioned this pull request Aug 5, 2025
Merged
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Aug 10, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2025
@ntnn ntnn closed this Aug 14, 2025
@ntnn ntnn deleted the kcp-1.33.3-diff branch August 14, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/cli Issues or PRs related to CLI changes dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ntnn @kcp-ci-bot