defer informer creation for vap params#4103
Merged
kcp-ci-bot merged 3 commits intokcp-dev:mainfrom May 8, 2026
Merged
Conversation
On-behalf-of: SAP <simon.bein@sap.com> Signed-off-by: Simon Bein <simontheleg@gmail.com>
On-behalf-of: SAP <simon.bein@sap.com> Signed-off-by: Simon Bein <simontheleg@gmail.com>
kcp-ci-bot
added
release-note-none
mjudeikis
changed the title
kcp-ci-bot
added
the
do-not-merge/work-in-progress
Contributor
|
The main problem is that the params resource is on another shard, and the informer for params points to the local shard. So the instance of the VAP plugin on this shard cannot find the resource: |
On-behalf-of: SAP <simon.bein@sap.com> Signed-off-by: Simon Bein <simontheleg@gmail.com>
kcp-ci-bot
added
size/L
SimonTheLeg
changed the title
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
mjudeikis
approved these changes
May 8, 2026
Contributor
mjudeikis
left a comment
mjudeikis
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/cherry-pick release-0.31
Please create follow-up issue for this
Contributor
|
LGTM label has been added. DetailsGit tree hash: 5a07e4cf7ef0cacdaebc991ef579fc89d3b8155e |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Member
Author
|
@mjudeikis follow up has been created and is linked in the description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue when using VAP with parameters and enables full usage for single shards, both for VAP inside the same workspace and VAP in a different workspace, where the APIExport resides. Implementation for multi-shard is tracked in #4110
What Type of PR Is This?
/kind bug
Related Issue(s)
Fixes #
Release Notes