fix(bookcontent): scale alt headings with the selected text size#483
Merged
Conversation
AltHeadingItem used hardcoded font sizes (20/18/16sp per level), so alternate TOC headings did not follow the user's text size. Make the size relative to the base text size (x1.25 / x1.125 / x1.0), preserving the previous values at the default 16sp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AltHeadingItemused hardcoded font sizes (20/18/16sp depending on level), so the alternate TOC headings rendered in the book content did not follow the user's chosen text size (keyboard, zoom buttons, pointer zoom).This makes the heading size relative to the base text size (×1.25 / ×1.125 / ×1.0). At the default 16sp the rendered values are unchanged (20/18/16), but they now scale with the rest of the content.