fix(home): show book autocomplete popup only for the selected tab#489
Merged
Conversation
The suggestion state lives in a single shared SearchHomeViewModel while every open tab stays composed. Since a Popup renders in its own window and escapes the layout(0,0) trick that hides non-selected tabs, each composed tab drew a duplicate suggestions popup. Gate the overlay on LocalTabSelected so only the active tab renders it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a duplicate book-autocompletion popup on the Home page (reported as the "כפול" / double popup).
Root cause:
SearchHomeViewModel, but every open tab stays composed permanently (non-selected tabs are measured withlayout(0, 0) {}so they draw nothing).Popuprenders in its own window and escapes thatlayout(0, 0)trick. So wheneversuggestionsVisible = true, every composed tab whoseSearchBaris in reference mode drew its own popup window → two identical popups overlapping at different anchors.Fix:
SearchBaronLocalTabSelected.current, so only the currently selected tab renders the popup. Reuses the existingLocalTabSelectedcomposition local already used elsewhere for per-tab gating.Test plan