Skip to content

run integration tests in pipeline 🪠#13

Merged
soustruh merged 2 commits intomainfrom
feature/CFT-3479-run-from-git
Jul 15, 2025
Merged

run integration tests in pipeline 🪠#13
soustruh merged 2 commits intomainfrom
feature/CFT-3479-run-from-git

Conversation

@soustruh
Copy link
Copy Markdown
Contributor

@soustruh soustruh commented Jul 15, 2025

  • run integration tests in pipeline 🪠
  • brief description of the venv parameter + updated examples 🐍

@soustruh soustruh force-pushed the feature/CFT-3479-run-from-git branch from 8df03fc to da2930e Compare July 15, 2025 00:10
@soustruh soustruh force-pushed the feature/CFT-3479-run-from-git branch from da2930e to e75e7ec Compare July 15, 2025 00:12
@soustruh soustruh requested review from a team and Copilot July 15, 2025 00:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds integration tests to the CI pipeline and documents a new venv parameter for Python environments.

  • Updated docker-compose to improve indentation, add a test service and set user permissions.
  • Extended README with details and examples for the new venv parameter.
  • Enhanced GitHub Actions workflow to run unit tests and a new integration test job.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
docker-compose.yml Fixed indentation in dev volumes and added a test service with user settings and updated environment paths
README.md Added documentation for venv parameter and updated JSON examples
.github/workflows/push.yml Renamed unit-test steps and introduced a tests-integration job
Comments suppressed due to low confidence (3)

.github/workflows/push.yml:165

  • [nitpick] Hardcoding the number of integration test iterations can lead to errors if tests are added or removed. Consider iterating over the actual config files with a glob pattern, e.g., for file in tests/config-*.json; do.
          for i in {1..8}; do

docker-compose.yml:14

  • The test service no longer mounts the host code directory, which may prevent build_n_test.sh from accessing the latest code. Ensure this is intentional or reintroduce the - ./:/code volume mount if needed.
    volumes:

README.md:23

  • [nitpick] You've introduced a new venv parameter; consider adding unit or integration tests to verify that each supported value (3.12, 3.13, 3.14, base) is handled correctly.
- `venv`: String with one of the following values:

Comment thread .github/workflows/push.yml
@soustruh soustruh merged commit 9b5bbb2 into main Jul 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants