Conversation
Contributor
|
feature not needed anymore... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to enhance functionality, improve maintainability, and modernize dependencies. Key changes include upgrading the Python version in the
Dockerfile, adding support for metadata extraction in reports, and improving file handling in thesrc/component.pymodule. Below is a detailed breakdown of the most important changes grouped by theme.Dependency and Environment Updates:
Dockerfilefrompython:3.10-slimtopython:3.11-slimto leverage the latest Python features and performance improvements.Metadata Extraction and Reporting Enhancements:
metadata_fieldsproperty to the configuration schema incomponent_config/configRowSchema.json, allowing users to specify metadata fields to include in the report.extract_report_metadataandwrite_metadata_tablemethods insrc/component.pyto extract and write metadata fields from a report response to a CSV file. These methods are used when theinput_variantis set toexisting_report_id. [1] [2]metadata_fieldsattribute to theConfigurationclass insrc/configuration.pyto store the list of metadata fields specified by the user.File Handling Improvements:
os.makedirscalls inwrite_reportandwrite_metadata_tablemethods insrc/component.py. This prevents potential errors when the target directory does not exist. [1] [2]