Conversation
Contributor
Author
|
@keboola-pr-reviewer review |
![keboola-pr-reviewer[bot]](https://avatars.githubusercontent.com/u/1424387?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verdict: needs_human (risk 3/5) · profile component-factory
The Dockerfile upgrades the runtime Python base image from 3.10-slim to 3.14-slim — a four-minor-version jump on a customer-facing extractor (kds-team.ex-dv360).
Concerns:
Dockerfile: Python 3.10-slim → 3.14-slim is a large runtime jump on a customer-facing extractor. Python 3.14 was pre-release at the time of the last known stable cycle; verify it is GA and that all pinned runtime dependencies (google-api-python-client, google_auth_oauthlib, dataconf, keboola.utils) are confirmed compatible before merging.requirements.txt: freezegun is listed as a runtime dependency (not dev-only) and is being bumped from ~=1.2.2 to ~=1.5.2. Confirm whether freezegun is actually used at runtime or should be moved to a dev-only group.
Suggested reviewers: @keboola/component-factory
soustruh
previously approved these changes
May 4, 2026
soustruh
previously approved these changes
May 5, 2026
soustruh
left a comment
soustruh
left a comment
There was a problem hiding this comment.
Approving with a room for a couple of improvements 🙏
kudj
force-pushed
the
fix/upgrade-python
branch
2 times, most recently
from
9b0d1c3 to
2d0364c
Compare
fix config dataclass
soustruh
approved these changes
May 5, 2026
soustruh
left a comment
soustruh
left a comment
There was a problem hiding this comment.
Awesome, thanks for replacing dataconf with pydantic! 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade python version.
Tested here: https://connection.north-europe.azure.keboola.com/admin/projects/17971/components/kds-team.ex-dv360/01kqh4mkt6dh2fvhxxa8y2y751/rows/01kqh4nd2j8pqdvt4yes10k8c7