fix cookie handling by refreshing page after loading cookies#4
Open
davidesner wants to merge 5 commits intomainfrom
Open
fix cookie handling by refreshing page after loading cookies#4davidesner wants to merge 5 commits intomainfrom
davidesner wants to merge 5 commits intomainfrom
Conversation
davidesner
force-pushed
the
de-fix-cookie-handling
branch
from
ae8a921 to
fd3ab2b
Compare
davidesner
force-pushed
the
de-fix-cookie-handling
branch
2 times, most recently
from
b31acc7 to
a96345f
Compare
davidesner
force-pushed
the
de-fix-cookie-handling
branch
from
a96345f to
6508aaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the web crawler component, focusing on more robust cookie handling and minor code cleanups. The main changes ensure that cookies are properly applied by refreshing the browser after loading cookies, and clarify some configuration parameter defaults.
Web crawler improvements:
refresh_pagemethod to theSeleniumCrawlerclass, which refreshes the browser to ensure cookies are applied after loading.runmethod incomponent.pyto callrefresh_pageand wait for 2 seconds after loading cookies, ensuring proper session restoration.Configuration and code cleanup:
component.pyto includetimefor the new sleep logic.docker_modeconfiguration parameter by providing a default value directly in thegetcall. Otherwise the docker mode was always true when provided