feat(ignore): .kbcignore support for notification subscriptions#2546
Draft
Matovidlo wants to merge 1 commit intomvasko/notification-subscriptions-supportfrom
Draft
feat(ignore): .kbcignore support for notification subscriptions#2546Matovidlo wants to merge 1 commit intomvasko/notification-subscriptions-supportfrom
Matovidlo wants to merge 1 commit intomvasko/notification-subscriptions-supportfrom
Conversation
Wire up full .kbcignore support for NotificationState objects: Pattern syntax: keboola.component/config-id/notifications → ignore all notifications for config keboola.component/config-id/notifications/sub-xxx → ignore specific notification Changes: - ignore.go: rename IgnoreConfigsOrRows → IgnoreObjects; add 3-part "notifications" and 4-part "notifications/<id>" cases to applyIgnorePattern - registry.go: add IgnoreNotificationsForConfig, IgnoreNotification, IgnoredNotifications methods; extend NullIgnoredBranchStates to also null NotificationState objects belonging to ignored branches - pull/operation.go: null remote state for ignored notifications in ignoreObjects - push/operation.go: null both states for ignored notifications before diff - Tests: add notification objects to test registries, add test cases for all new patterns and registry methods Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
Added
.kbcignoresupport for notification subscriptions. Users can now exclude specific notifications or all notifications for a config from pull/push operations using these patterns:Plans for customer communication
None.
Impact analysis
IgnoreConfigsOrRows()→IgnoreObjects()rename is internal (only called in pull/push operations).kbc pulldiff (remote state nulled) and will not be pushed bykbc push(both states nulled).NullIgnoredBranchStates()— previously this was a gap.Change type
Feature (non-breaking)
Justification
Notification subscriptions were the only object type without
.kbcignoresupport despite having theIgnore boolfield already present onNotificationState.Deployment
Merge & automatic deploy.
Rollback plan
Revert of this PR.
Post release support plan
None.