Skip to content

fix(output-mapping): improve error message for missing output mapping source files #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jerab111 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(output-mapping): improve error message for missing output mapping source files #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion libs/output-mapping/src/SourcesValidator/LocalSourcesValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,12 @@ public function validatePhysicalFilesWithConfiguration(array $dataItems, array $
// well, we probably should care about missing write-always sources :-/
if (!$this->isFailedJob) {
throw new InvalidOutputException(
sprintf('Table sources not found: %s', implode(', ', $invalidSources)),
sprintf(
'Output mapping error: The source file %s was not found. '
. 'Verify that the transformation code creates this file in the output directory, '
. 'or remove the corresponding output mapping if the file is no longer needed.',
implode(', ', $invalidSources),
),
404,
);
}
Expand Down
4 changes: 3 additions & 1 deletion libs/output-mapping/tests/SourceValidator/LocalSourcesValidatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ public function testValidatePhysicalFilesWithManifestWithOrphanedManifest(): voi
public function testValidatePhysicalFilesWithConfigurationWithMissingSource(): void
{
$this->expectException(InvalidOutputException::class);
$this->expectExceptionMessage('Table sources not found: "missing.source"');
$this->expectExceptionMessage(
'Output mapping error: The source file "missing.source" was not found.',
);

$dataItems = [$this->createMock(FileItem::class)];
$configurationSource = [$this->createConfiguredMock(
Expand Down
4 changes: 2 additions & 2 deletions libs/output-mapping/tests/Writer/StorageApiLocalTableWriterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ public function testWriteTableOutputMappingMissing(): void
],
];
$this->expectException(InvalidOutputException::class);
$this->expectExceptionMessage('Table sources not found: "table81.csv"');
$this->expectExceptionMessage('Output mapping error: The source file "table81.csv" was not found.');
$tableQueue = $this->getTableLoader()->uploadTables(
configuration: new OutputMappingSettings(
configuration: ['mapping' => $configs],
Expand Down Expand Up @@ -1771,7 +1771,7 @@ public function testLocalTableUploadChecksForUnusedMappingEntries(): void
$stagingFactory = $this->getLocalStagingFactory(logger: $this->testLogger);

$this->expectException(InvalidOutputException::class);
$this->expectExceptionMessage('Table sources not found: "unknown.csv"');
$this->expectExceptionMessage('Output mapping error: The source file "unknown.csv" was not found.');
$this->getTableLoader(
logger: $this->testLogger,
strategyFactory: $stagingFactory,
Expand Down
Loading