feat(query-service-api-client): add refreshMetadataOnSuccess to submitQueryJob PHPDoc#481
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
Conversation
…tQueryJob PHPDoc Co-Authored-By: Martin Vasko <Matovidlo2@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
@MiroCillik nevim ci tohle staci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
refreshMetadataOnSuccess?: boolto the PHPDoc@paramarray shape forsubmitQueryJob()in the query-service-api-client library. This documents the new optional boolean field already supported by the Query Service backend (go-monorepo), which triggers workspace metadata refresh after successful query execution.This is a documentation-only change — no runtime behavior is modified. The method passes the request body array through to the API as-is.
Review & Testing Checklist for Human
refreshMetadataOnSuccessand typeboolmatch the backend API contract ingo-monorepo/services/query/api/handlers/submit.gosubmitQueryJobin the codebase need to be updated to pass this fieldNotes
refreshMetadataOnSuccessacross all Query Service SDKs (Python, JS, PHP, MCP server).SubmitQueryJobRequest.RefreshMetadataOnSuccessin the go-monorepo query service.Release Notes
Justification, description
Added
refreshMetadataOnSuccessoptional boolean to thesubmitQueryJobPHPDoc type hint, aligning the PHP client documentation with the backend API contract.Plans for Customer Communication
N/A
Impact Analysis
PHPDoc-only change. No runtime behavior affected.
Deployment Plan
N/A
Rollback Plan
N/A
Post-Release Support Plan
N/A
Link to Devin session: https://app.devin.ai/sessions/f269ff38856946e6b8a0f3b6c84eab0b