feat(sandboxes-service-api-client): add type filter and type field to AppsApiClient#490
Open
feat(sandboxes-service-api-client): add type filter and type field to AppsApiClient#490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/keboola/issue/AJDA-1942
Description
Adds a
$typesarray parameter toAppsApiClient::listApps()that sendstype[]=valuequery params to the/appsendpoint, enabling server-side filtering by app type (e.g.python,r,streamlit). Also maps the nullabletypefield from theExistingAppAPI response into theAppmodel.Release Notes
Change Type
New feature — adds type filtering support and exposes the
typefield on theAppmodel.Justification
The CLI needs to list only Python/R sandbox apps when replacing the legacy sandboxes-api with the new apps API. Without this filter, callers would receive all app types and have to filter client-side.
Plans for Customer Communication
No customer communication needed — this is an internal API client library used by other Keboola services.
Impact Analysis
Low risk. Additive change only: new optional parameter defaults to
[](no filtering), and the newtypefield onAppis nullable. No breaking changes.Deployment Plan
Standard CI/CD continuous deployment across all stacks.
Rollback Plan
Standard git revert if issues detected post-deployment.
Post-Release Support Plan
No follow-up actions needed.