PAT-1772 Add Mode and Dev fields to App v2 spec#492
Open
pepamartinec wants to merge 2 commits intomainfrom
Open
PAT-1772 Add Mode and Dev fields to App v2 spec#492pepamartinec wants to merge 2 commits intomainfrom
pepamartinec wants to merge 2 commits intomainfrom
Conversation
pepamartinec
force-pushed
the
pepa/PAT-1772_devMode
branch
from
a122af2 to
9d7500d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
https://linear.app/keboola/issue/PAT-1772/mvp-dev-mode-for-data-apps
Adds
modeanddevto the v2AppSpectyped model so consumers — primarilysandboxes-service— can serialise and deserialise the new dev-mode fields through the typed client without resorting to raw HTTP reads orextraSpecFieldspatch shortcuts. The CRD itself is being extended inkeboola-operator(see PAT-1772); this PR is the matchingkeboola/k8s-clientmodel update.modeis a string ("prod"or"dev");devis a new optionalAppDevSpeccarryinggitPollInterval(ISO-8601 duration string, e.g."1s","5m") andautoRunSetupOnDepChange(bool). TheAppModelTestround-trip is extended to assert both fields hydrate and serialise correctly.Plans for customer communication
None.
Impact analysis
No end-user impact. New optional fields on the typed model; existing callers that don't set or read them are unaffected.
Change type
New feature
Justification
Unblocks
sandboxes-serviceplumbing for the data-app dev-mode MVP (PAT-1772).Deployment
Merge & automatic deploy.
Rollback plan
Revert of this PR.
Post release support plan
None.