Fix decoding error for strings with leading 1's#21
Open
a2hill wants to merge 1 commit intokeefertaylor:masterfrom
Open
Fix decoding error for strings with leading 1's#21a2hill wants to merge 1 commit intokeefertaylor:masterfrom
a2hill wants to merge 1 commit intokeefertaylor:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 50 53 +3
=========================================
+ Hits 50 53 +3
Continue to review full report at Codecov.
|
|
@keefertaylor I just hit this issue (#18, #23, #25) and it looks like this PR may resolve it. Any chance you could look it over, potentially merging and releasing an update so that BS58Swift encodes and decodes more consistently? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation improperly decodes Base58 strings with leading 1's (see #18 ). As a result
base58CheckDecodefails. I've fixed the decoding implementation and added two tests. One to verify thatbase58CheckDecodeworks for strings with leading 1's and another to verify that a string with all 1's will decode correctly.