feat: improve service name extraction in Cilium provider#5581
Open
PoornaChandra2005 wants to merge 1 commit intokeephq:mainfrom
Open
feat: improve service name extraction in Cilium provider#5581PoornaChandra2005 wants to merge 1 commit intokeephq:mainfrom
PoornaChandra2005 wants to merge 1 commit intokeephq:mainfrom
Conversation
dosubot
bot
added
the
size:XS
Contributor
|
Target branch is not in the allowed branches list. |
|
@PoornaChandra2005 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5411
This PR improves how service names are extracted in the Cilium topology map.
Changes:
Added support for extracting names from k8s:io.kubernetes.container.name and k8s:io.cilium.k8s.policy.service-name labels.
Ensures that the topology map shows human-readable service names instead of just IP addresses when the data is available in labels.