feat(sandbox): add Show on Device for Get Address, fix BTC/LTC path handling#21
Open
0xMillz wants to merge 4 commits intokeepkey:developfrom
Open
feat(sandbox): add Show on Device for Get Address, fix BTC/LTC path handling#210xMillz wants to merge 4 commits intokeepkey:developfrom
0xMillz wants to merge 4 commits intokeepkey:developfrom
Conversation
Sync develop to master for v1.0.2 release
…andling - Add 'Show on Device' option to Get Address for Bitcoin, Cosmos, Litecoin, Dogecoin, Ripple, THORChain (closes keepkey#16) - Fix 'Wrong address path for selected coin' by normalizing derivation path purpose (44/49/84/86) to match address type - Sync Derivation Path field when Address Type dropdown changes - refactor(keepkey): convert Solana namespaces to ES module interfaces (fixes @typescript-eslint/no-namespace)
|
@0xMillz is attempting to deploy a commit to the keepkey-v2 Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #16 and related improvements.
Changes
@typescript-eslint/no-namespace)Testing
Manually tested with KeepKey device.