chore: remove native wallet packages, migrate CI to GitHub Actions#24
Closed
BitHighlander wants to merge 1 commit intomasterfrom
Closed
chore: remove native wallet packages, migrate CI to GitHub Actions#24BitHighlander wants to merge 1 commit intomasterfrom
BitHighlander wants to merge 1 commit intomasterfrom
Conversation
…tions, fix build - Remove hdwallet-native and hdwallet-native-vault (unused, caused build errors) - Delete .circleci/config.yml, add .github/workflows/ci.yml - Fix ethers/lib/utils.js import in ethereum.ts (inline helpers) - Fix ArrayBuffer/SharedArrayBuffer type casts across transport files - Clean up native references from integration tests and sandbox
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
Splitting into separate PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hdwallet-nativeandhdwallet-native-vaultpackages (unused, caused FIO type errors)What changed
packages/hdwallet-native/(~100 files, ~12K lines)packages/hdwallet-native-vault/.circleci/config.yml.github/workflows/ci.yml— Node 16, yarn, build + lint + testethereum.ts— inlinedarrayify/isBytes/isHexString(was importing from missingethers)utils.ts,transport.ts—ArrayBuffercasts for TS5 SharedArrayBuffer compat@keepkey/hdwallet-nativeimportsTest plan
yarn buildpasses