chore: remove hdwallet-native and hdwallet-native-vault packages#26
Closed
BitHighlander wants to merge 6 commits intomasterfrom
Closed
chore: remove hdwallet-native and hdwallet-native-vault packages#26BitHighlander wants to merge 6 commits intomasterfrom
BitHighlander wants to merge 6 commits intomasterfrom
Conversation
Remove unused native wallet packages that caused FIO type build errors. Fix pre-existing TypeScript errors (ethers import, ArrayBuffer casts). Clean up all native references from integration tests and sandbox.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
2 tasks
- Add bs58, bs58check as direct dependencies of hdwallet-keepkey (were phantom-hoisted from removed hdwallet-native) - Add @types/bs58, @types/bs58check as devDependencies - Fix prettier formatting in transport.ts (line too long from cast) - Remove unused testPublicWalletXpubs and $native from sandbox - Apply eslint autofix (import sort, prettier, blank lines) - Suppress pre-existing namespace lint errors in solana.ts
Delete .circleci/config.yml and add .github/workflows/ci.yml. Runs build, lint, and unit tests on Node 16 for PRs and pushes to master.
ci: replace CircleCI with GitHub Actions
1 task
Collaborator
Author
|
Replaced by new PR with clean history rebased on ci/setup (PR #28) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hdwallet-nativeandhdwallet-native-vaultpackages (unused in vault v11)ArrayBuffer | SharedArrayBuffertype errors across transport filesethers/lib/utils.jsimports inhdwallet-keepkeywith inline helperstsconfig.jsonandpackage.jsonto remove native package referencesDetails
The
hdwallet-nativepackage had accumulated build-breaking issues (FIOExternalSignerAdaptertype mismatch, missing ethers dependency) and is not used by the KeepKey hardware wallet stack. Allhdwallet-keepkey-*packages are preserved.TypeScript 5.x strict mode fixes:
as ArrayBuffercasts inhdwallet-core/utils.ts,hdwallet-keepkey/transport.ts,hdwallet-keepkey-nodewebusb/transport.ts,hdwallet-keepkey-webusb/transport.tsEthers removal in
hdwallet-keepkey/ethereum.ts:isHexString(),isBytes(),arrayify()— ethers was never a declared dependencyTest plan
yarn install && yarn buildpasses cleanlyhdwallet-keepkey-*packages build without errorshdwallet-nativeremain in codebase