Remove dead white-label variants, add BTC-only build#370
Draft
BitHighlander wants to merge 4 commits intodevelopfrom
Draft
Remove dead white-label variants, add BTC-only build#370BitHighlander wants to merge 4 commits intodevelopfrom
BitHighlander wants to merge 4 commits intodevelopfrom
Conversation
Remove QTUM, BNB, ZIL, GTO, IOST, CMT, MCO, and ODEM from tokens.def. These tokens were listed as ERC-20 entries in the legacy coin table but their contract addresses no longer exist in the generated uniswap_tokens table (they migrated to their own L1 chains or were delisted). This causes Coins.TableSanity unit test to fail because tokenByTicker() finds them in coins[] but tokenByChainAddress() cannot locate them in tokens[], returning UnknownToken. The native chain entries for QTUM, BNB, etc. in coins.def are unaffected (they have has_contract_address=false). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4-stage fail-fast pipeline: gate (lint, secrets, submodules) → build (emulator + ARM cross-compile) → test (unit + Python integration) → publish (manual DockerHub push). Downloadable firmware artifacts with version-tagged naming. CircleCI config removed.
Remove unused variant builds (salt, fox, kaspersky, blockpit, dash) that compiled on every build but are no longer shipped. Add KK_BITCOIN_ONLY cmake option to produce a BTC-only firmware with altcoin sources and crypto excluded. Add parallel CI job for BTC-only ARM cross-compilation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Depends on ci migration first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KK_BITCOIN_ONLYcmake option that excludes altcoin sources and crypto from the firmware buildbuild-arm-firmware-btconly) producing a BTC-only firmware artifactFiles changed
CMakeLists.txtKK_BITCOIN_ONLYoption, conditionalUSE_*defineslib/firmware/CMakeLists.txtethereum_tokensdeps/crypto/CMakeLists.txtlib/firmware/fsm.c#if !BITCOIN_ONLYguards on altcoin headers and handlerslib/firmware/fsm_msg_common.hlib/firmware/messagemap.deflib/firmware/transaction.clib/board/variant.ctools/variant/CMakeLists.txttools/firmware/CMakeLists.txtkkvariant.saltfrom link listlib/variant/CMakeLists.txtkkvariant.saltlibrary.github/workflows/ci.ymlbuild-arm-firmware-btconlyjobtools/variant/{salt,fox,kaspersky,blockpit,dash}.c,lib/variant/salt/,include/keepkey/variant/salt.hTest plan
build-arm-firmware)build-arm-firmware-btconly)