Use InputSystem.onBeforeUpdate instead of manually hooking into player loop#47
Open
TheNathannator wants to merge 1 commit intokeijiro:masterfrom
Open
Use InputSystem.onBeforeUpdate instead of manually hooking into player loop#47TheNathannator wants to merge 1 commit intokeijiro:masterfrom
TheNathannator wants to merge 1 commit intokeijiro:masterfrom
Conversation
Owner
|
Thanks for the PR. I had realized this approach recently as well but couldn't afford the time to update the code. I'll run some tests, and if everything looks good, I'll merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The input system package provides its own update callbacks that can be hooked into for updating state. These callbacks are called in both play mode and edit mode, and using
onBeforeUpdateguarantees that inputs are queued and processed in the same update (instead of being delayed for a frame).