Fix TypeError building key error message for a tuple key (#253)#347
Merged
skorokithakis merged 1 commit intoJun 13, 2026
Merged
Conversation
When a key's value failed validation, the error message was built with `"Key '%s' error:" % nkey`. If the key is a tuple (including the empty tuple), `%` treats it as the format arguments rather than a single value, so an empty tuple key raised `TypeError: not enough arguments for format string` and other tuple keys would consume their elements as multiple format args. Wrap the key in a single-element tuple (`% (nkey,)`) so it is always formatted as one value. Fixes keleshev#253 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
skorokithakis
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #253.
When a key's value fails validation, the key error message is built with:
If
nkeyis a tuple,%interprets it as the format arguments rather than a single value. For the empty tuple this raisesTypeError: not enough arguments for format string, and for other tuple keys it would consume the tuple's elements as multiple format args.Wrapping the key in a single-element tuple (
% (nkey,)) formats it as one value:Added
test_tuple_key_error_message_does_not_crash, which fails onmasterand passes with this change. All 118 existing tests still pass.Disclosure: prepared with AI assistance; reviewed by me and I can explain every line.