-
-
Notifications
You must be signed in to change notification settings - Fork 30
feat(scadm): dynamic OpenSCAD version resolution #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kellervater
merged 17 commits into
main
from
copilot/dynamic-openscad-version-resolution
Apr 18, 2026
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
3dc78a8
Initial plan
Copilot 820a163
feat(scadm): add dynamic OpenSCAD version resolution
Copilot 62e5193
feat(scadm): update Renovate config, docs, and test assertions
Copilot 975665c
refactor(scadm): address code review feedback
Copilot 987606b
fix(scadm): pass force flag to version info display
kellervater fbf4b38
fix(scadm): address review feedback on resolver and config validation
kellervater 47567cd
refactor(scadm): remove dead constants.py module
kellervater fa08c3a
test(scadm): add CLI integration tests and CI workflow
kellervater f731903
chore(scadm): pin nightly OpenSCAD version
kellervater adbaf2f
fix(renovate): use jsonata manager for scadm.json version tracking
kellervater a8ef579
test: pin OpenSCAD to older version for Renovate validation
kellervater 50089b6
revert: restore OpenSCAD version to 2026.04.16 after Renovate validation
kellervater ce86866
fix(ci): add pytest-timeout to integration test dependencies
kellervater 3b9fae9
fix(scadm): track installed version via marker file
kellervater 86b97f8
fix: exclude integration tests from pre-commit hook
kellervater f73eda8
fix: address review comments
kellervater 6eaec03
fix(ci): add shell: bash to integration test step for Windows
kellervater File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| --- | ||
| name: Integration Tests | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'cmd/scadm/**' | ||
| - 'scadm.json' | ||
| - '.github/workflows/integration-tests.yml' | ||
| - '.github/actions/setup-openscad/**' | ||
|
|
||
| jobs: | ||
| integration: | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest, windows-latest] | ||
| runs-on: ${{ matrix.os }} | ||
| permissions: | ||
| contents: read | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v6 | ||
|
|
||
| - name: Set up Python | ||
| uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: '3.14' | ||
|
|
||
| - name: Install scadm from source | ||
| run: pip install -e cmd/scadm pytest pytest-timeout | ||
|
|
||
| - name: Install libfuse2 (Linux AppImage support) | ||
| if: runner.os == 'Linux' | ||
| run: | | ||
| set -euo pipefail | ||
| sudo apt-get update | ||
| sudo apt-get install -y --no-install-recommends libfuse2 | ||
|
|
||
| - name: Run integration tests | ||
| shell: bash | ||
| run: | | ||
|
kellervater marked this conversation as resolved.
|
||
| set -euo pipefail | ||
| cd cmd/scadm | ||
| python -m pytest tests/test_cli_integration.py -m integration -v --timeout=300 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.