Skip to content

Generalize site search for all registered sources and normalize result URLs - #263

Open
kmatsunami wants to merge 1 commit into
mainfrom
codex/add-search-functionality-for-all-media-brpswn
Open

Generalize site search for all registered sources and normalize result URLs#263
kmatsunami wants to merge 1 commit into
mainfrom
codex/add-search-functionality-for-all-media-brpswn

Conversation

@kmatsunami

Copy link
Copy Markdown
Collaborator

Motivation

  • Expand the search capability to cover all registered sources instead of the previous two hard-coded sources.
  • Unify duplicate per-site search logic into a single generic extractor to simplify maintenance and add per-source configuration.
  • Ensure discovered result URLs are resolved, domain-checked, and canonicalized to existing seed URL normalization logic.

Description

  • Replaced hard-coded SUPPORTED_SEARCH_SOURCES with REGISTERED_SOURCES and imported normalize_seed_url from manga_watch.sources and switched quote to quote_plus for query encoding.
  • Added _SOURCE_SEARCH_CONFIG to declare each source's search_url and allowed_domains and implemented _search_via_public_site to drive searches for any configured source.
  • Reworked anchor parsing into _extract_anchor_results and added helpers _resolve_result_url, _is_allowed_domain, and _canonical_seed_url_for_source to resolve relative links, enforce allowed domains, and produce canonical seed URLs via normalize_seed_url.
  • Removed source-specific search functions and _normalize_result_url, and built _SEARCHERS dynamically so each registered source uses the generic search path.

Testing

  • Ran updated unit tests in tests/test_source_search.py which assert supported sources and seed URL normalization and they passed.
  • Ran tests/test_discord_command_registration_search.py which validates the expanded search choices and it passed.
  • Ran tests/test_discord_supertwins.py which checks search invocation behavior and it passed.

Codex Task

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 23f45b635e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

from manga_watch.sources.base import HttpClient, RequestsHttpClient

SUPPORTED_SEARCH_SOURCES: tuple[str, ...] = ("champion-cross", "kakuyomu")
SUPPORTED_SEARCH_SOURCES: tuple[str, ...] = tuple(REGISTERED_SOURCES)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Bound synchronous source fan-out to avoid command timeouts

Making SUPPORTED_SEARCH_SOURCES equal to every registered adapter means supertwins search now fans out synchronously across up to 13 non-root sources (_search_results loops sources one-by-one and each call does blocking HTTP). With the current HTTP defaults (25s timeout and retries), one slow/unreachable site can stall a source search for a long time, so a single interaction can exceed Discord response windows by minutes. This regression is introduced by expanding the source list without adding parallelism or tighter fail-fast behavior.

Useful? React with 👍 / 👎.

Comment on lines +190 to +191
if normalized.startswith("/"):
normalized = urljoin(search_url, normalized)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Resolve all relative href forms before URL validation

_resolve_result_url currently resolves only root-relative links (/path) and drops document-relative links like works/123, ./episode/..., or ../series/... because they reach urlsplit without a scheme and are rejected. That means valid anchors can silently disappear from results on sites that emit non-root relative URLs. The previous implementation used urljoin for all hrefs, so this is a behavior regression in link extraction.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant