fix: validate magapoke RSS URL before fetch to prevent SSRF - #320
Open
kentoku24 wants to merge 1 commit into
Open
fix: validate magapoke RSS URL before fetch to prevent SSRF#320kentoku24 wants to merge 1 commit into
kentoku24 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
extract_magapoke_rss_urlby importingurlparse, and introducing_ALLOWED_RSS_SCHEMESand_ALLOWED_RSS_HOSTSallowlists.http/httpsor whose hostname is not in the trusted set, returningNoneto trigger the existing fallback tocanonical_magapoke_rss_url.tests/test_sources.pyto ensure non-HTTP schemes and untrusted hosts in the title page RSS link are ignored and the adapter falls back to the canonical feed URL.Testing
PYTHONPATH=. pytest -q tests/test_sources.py -k magapokewhich passed with5 passed, 58 deselected, 1 subtests passed.pytestwithoutPYTHONPATH=.failed during collection in this environment withModuleNotFoundError: No module named 'manga_watch', which is an environment setup issue rather than a code regression.Codex Task