Skip to content

fix: ensure AI Assistant restart clears conversation history (#3261) #3317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pierreeurope wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: ensure AI Assistant restart clears conversation history (#3261) #3317

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8ee7ef
fix: ensure AI Assistant restart clears conversation history (#3261)
pierreeurope Feb 10, 2026
82cad0c
Merge branch 'master' into fix/issue-3261
lixun910 Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/ai-assistant/src/components/ai-assistant-component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,15 +106,21 @@ export function AiAssistantComponent() {
}, [datasetMetaData]);

const onRestartAssistant = async () => {
// Clear Redux state first
dispatch(updateAiAssistantMessages([]));


// Clear library's internal state
try {
await restartChatRef.current();
} catch (e) {
console.error('Error restarting chat:', e);
}

setRestartKey(prev => prev + 1);

// Force remount after state has been cleared
// Use setTimeout to ensure Redux state update has propagated
Comment on lines +118 to +120
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setTimeout schedules a state update that can still fire after AiAssistantComponent unmounts (e.g., when switching to config view or closing the panel), which can trigger React warnings and unnecessary work. Consider storing the timeout id in a ref and clearing it in a useEffect cleanup (or guarding the callback with an isMounted ref) before calling setRestartKey.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator

@lixun910 lixun910 Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot check if this comment makes sense and if yes, apply changes based on this feedback

setTimeout(() => {
setRestartKey(prev => prev + 1);
}, 0);
};

const onMessagesUpdated = (messages: MessageModel[]) => {
Expand Down
Loading