fix(geojson-layer): add null-safety checks to prevent crashes on malformed features (#2383)#3337
Open
pierreeurope wants to merge 1 commit intokeplergl:masterfrom
Open
Conversation
…ormed features (keplergl#2383) - Add null check for feature, feature.geometry, and feature.geometry.coordinates in applyFiltersToTableColumns before accessing coordinates (fixes crash when dataToFeature contains null entries) - Fix logic error where feature was checked for truthiness AFTER already accessing feature.geometry - Add empty features array check in parseGeoJsonRawFeature normalization - Use optional chaining for center() geometry access Closes keplergl#2383 Signed-off-by: pierreeurope <pierre.europe@pm.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds defensive null checks in geojson-utils to prevent "Cannot read properties of undefined" crashes when processing GeoJSON data with null or malformed features.
Problem
When loading CSV data with a geojson column, certain rows may contain empty, null, or malformed geometry data. This causes crashes like:
The
dataToFeaturearray can containnullentries for rows where geometry parsing failed, but some code paths accessed properties without checking for null first.Changes
src/layers/src/geojson-layer/geojson-utils.tsapplyFiltersToTableColumns: Added null check forfeature,feature.geometry, andfeature.geometry.coordinatesbefore iterating coordinates. Previously, the code accessedfeature.geometry.coordinatesbefore checking iffeaturewas truthy (the check was in the wrong order on the next line).parseGeoJsonRawFeature: Added check for emptynormalized.featuresarray to prevent accessingfeatures[0]on an empty array.getGeojsonLayerMeta: Used optional chaining forcenter()result geometry access, since the turf center function could theoretically return unexpected results for degenerate geometries.Closes #2383