Adding separate methods to extract the timestamp at which the keyframes occur.#35
Open
AkashWudali12 wants to merge 2 commits intokeplerlab:masterfrom
Open
Adding separate methods to extract the timestamp at which the keyframes occur.#35AkashWudali12 wants to merge 2 commits intokeplerlab:masterfrom
AkashWudali12 wants to merge 2 commits intokeplerlab:masterfrom
Conversation
…ilepath list to KeyFrameDiskWriter class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This PR introduces separate methods and helper functions to return both the extracted keyframes and their associated temporal data. Specifically:
These methods maintain the original functionality while also returning:
This enhancement enables future features, such as matching video transcripts or audio to keyframes, thereby improving the contextual understanding of the keyframes by adding more detailed metadata.
Bug Fix: Additionally, this PR addresses a bug found in the image_selector.py file, where the variance_laplacians list was occasionally empty.
Why This is Useful