Add start URL flags to browser commands#161
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
927fa45 to
ed7a71f
Compare
|
Firetiger deploy monitoring skipped This PR didn't match the auto-monitor filter configured on your GitHub connection:
Reason: PR modifies browser commands and CLI flags, not the kernel API endpoints (packages/api/cmd/api/) or Temporal workflows (packages/api/lib/temporal) specified in the filter. To monitor this PR anyway, reply with |
922d39a to
068a880
Compare
hiroTamada
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Note
Low Risk
Low risk CLI enhancement that adds optional flags and output fields; main risk is minor behavior changes in flag validation and pool update semantics.
Overview
Adds
--start-urlsupport tokernel browsers createandkernel browser-pools create/update, wiring it through to the SDK request params and displaying the configured/returned Start URL in human-readable outputs.Introduces
--clear-start-urlfor pool updates (mutually exclusive with--start-url) and rejects--start-urlvalues that look like another flag token (e.g.--headless) to prevent accidental mis-parsing.Bumps
kernel-go-sdktov0.53.0, adds tests covering the new start URL behavior, and updates README flag documentation.Reviewed by Cursor Bugbot for commit 068a880. Bugbot is set up for automated code reviews on this repo. Configure here.