fix: clean up npm artifacts before web-bot-auth build#95
Merged
Conversation
Removes package-lock.json and node_modules before npm install to avoid npm optional dependency resolution bugs. Ref: npm/cli#4828
f840aef to
4117d5c
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
archandatta
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package-lock.jsonandnode_modulesbeforenpm installto avoid npm optional dependency resolution bugsBackground
The npm install step can fail with optional dependency resolution issues. Removing these artifacts before install ensures a clean state.
Ref: npm/cli#4828
Test plan
kernel extensions build-web-bot-auth --to ./test-outputNote
Improves reliability of
web-bot-authextension build.npm install, deletepackage-lock.jsonandnode_modulesin the extracted repo to avoid an npm optional dependency bug; adds informational loggingWritten by Cursor Bugbot for commit 4117d5c. This will update automatically on new commits. Configure here.