Conversation
Migrate all tests in e2e_chromium_test.go from the old manual docker exec pattern to the TestContainer abstraction used by other e2e tests. Key changes: - Remove old helper functions (runContainer, stopContainer, waitHTTPOrExit, etc.) - Use NewTestContainer/Start/Stop pattern with dynamic port allocation - Update execCombinedOutput and helper functions to accept *TestContainer - Add t.Parallel() to all tests for parallel execution - Update logCDPDiagnostics in e2e_combined_flow_test.go for new signature This enables parallel test execution and removes ~300 lines of duplicate container management code. Co-authored-by: Cursor <cursoragent@cursor.com>
ulziibay-kernel
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e_chromium_test.gofrom the old manual docker exec pattern to theTestContainerabstractionrunContainer,stopContainer,waitHTTPOrExit, etc.)NewTestContainer/Start/Stoppattern with dynamic port allocationexecCombinedOutputand helper functions to accept*TestContainert.Parallel()to all tests for parallel executionlogCDPDiagnosticsine2e_combined_flow_test.gofor new signatureThis enables parallel test execution and removes ~300 lines of duplicate container management code. All e2e tests now consistently use the
TestContainerabstraction.Tests migrated
TestDisplayResolutionChangeTestExtensionUploadAndActivationTestScreenshotHeadlessTestScreenshotHeadfulTestInputEndpointsSmokeTestCDPTargetCreationTestWebBotAuthInstallationTest plan
Made with Cursor
Note
Medium Risk
Medium risk because it refactors test harness/container lifecycle and enables
t.Parallel()across Docker-backed E2E tests, which can surface port allocation, readiness, or race-condition issues without changing production code.Overview
Refactors
e2e_chromium_test.goto run all Chromium E2E scenarios via theTestContainerabstraction (dynamic ports +WaitReady/WaitDevTools) instead of hard-codeddocker run/kill/wait helpers, and removes the old container-management utilities.Enables parallel execution for these E2E tests (
t.Parallel()), updates remote exec helpers (execCombinedOutput,getXvfbResolution,listCDPTargets) to take*TestContainer, and adjusts the combined-flow diagnostics helper (logCDPDiagnostics) to exec inside the specific test container.Written by Cursor Bugbot for commit 873044a. This will update automatically on new commits. Configure here.