Phase 4 : Test suite plus alpha#3
Merged
Merged
Conversation
keshav-k3
commented
Sep 16, 2025
keshav-k3
commented
Owner
- ✅ Basic Tests: 5 runs, 11 assertions, 0 failures
- ✅ Comprehensive Tests: 7 runs, 28 assertions, 0 failures
- ✅ Core Logic: Configuration, Notifications, Base classes
- ✅ Delivery Methods: WebPush, Test mode
- ✅ Rails Integration: Railtie, Engine, ActiveJob
- ✅ Thread Pool Management: Working
- ✅ Web Push Dependencies: Installed and functional
keshav-k3
commented
Sep 17, 2025
| # Submit multiple tasks | ||
| futures = 3.times.map do |i| | ||
| pool.submit do | ||
| sleep 0.1 # Simulate work |
Owner
Author
There was a problem hiding this comment.
Check if 0.1 is enough, tbh this is a very rare trigger case, still
| config = ActionWebPush::Configuration.new | ||
| config.vapid_public_key = "test_public_key" | ||
| config.vapid_private_key = "test_private_key" | ||
| config.vapid_subject = "mailto:test@example.com" |
Owner
Author
There was a problem hiding this comment.
change all to test.com domain, example.com over use might trigger problems, check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.