fix(android): getJurisdiction/getRegion prefer locally-set values#130
Merged
ethanpschoen merged 2 commits intoJul 20, 2026
Conversation
…s first getJurisdiction()/getRegion() always fetched from the server, ignoring any value already set via setJurisdiction()/setRegion() on the same instance. Check the local field first and only fall back to the server-resolved value when nothing has been set locally, matching ketch-tag's override-before-fetch getter/setter model. Verified with a live-CDN instrumented test (KetchLocalFirstIntegrationTest): red before this change, green after, no regressions in the existing headless test suite.
…ationTest Per integration-tests/README.md's own contribution convention, headless CDN tests belong in KetchHeadlessIntegrationTest rather than a new file. Also drops the two redundant fallback-to-server assertions, which duplicated existing testGetJurisdictionReturnsJurisdictionCode/ testGetRegionReturnsRegionCode coverage without exercising anything the prior commit changed.
jboileau99
approved these changes
Jul 20, 2026
ethanpschoen
merged commit Jul 20, 2026
7df66de
into
justin/feat/cross-activity-lifecycle
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of this change
Why is this change being made?
How was this tested? How can the reviewer verify your testing?
Added two live-CDN instrumented tests to
KetchHeadlessIntegrationTest(testGetJurisdictionPrefersLocallySetValue,testGetRegionPrefersLocallySetValue) — confirmed red before this change, green after, on a real Android emulator against the production CDN (ketch_samples/android). No regressions in the rest of the headless suite or theketchsdkunit tests.Related issues
Reported by a customer blocked on Android headless testing; no tracked GitHub issue.
Checklist