fix(android): scope WebView teardown to the owning Activity#131
Merged
ethanpschoen merged 4 commits intoJul 21, 2026
Merged
Conversation
ethanpschoen
merged commit Jul 21, 2026
a47d4c6
into
justin/feat/cross-activity-lifecycle
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of this change
Why is this change being made?
How was this tested? How can the reviewer verify your testing?
Reproduced the failure live by adding a
TransientLoadActivitytosample-app-composethat callsload()then finishes immediately; logcat showed the boot progress to 80% thenwebViewClient coroutines cancelled, withonConfigUpdatednever firing, pre-fix. AddedZTransientActivityLoadSurvivesTest(integration-tests) reproducing the same mechanism viaActivityScenario— fails pre-fix (30s timeout), passes post-fix. Verified the fix wasn't a false positive by stashing just theKetch.ktchange and re-running the full 39-test instrumentation suite — identical failure set with/without it, confirming nothing else in the suite depends on the old unconditional-teardown behavior. Full suite (:integration-tests:connectedDebugAndroidTest) is 39/39 passing, and:ketchsdk:testDebugUnitTestpasses.Related issues
N/A — no tracked issue; found and fixed while investigating a customer-reported early-
load()failure.Checklist