Skip to content

add basic PlayerStats model and request#1

Open
JonasNicoletti wants to merge 3 commits into
kevinskyba:masterfrom
JonasNicoletti:master
Open

add basic PlayerStats model and request#1
JonasNicoletti wants to merge 3 commits into
kevinskyba:masterfrom
JonasNicoletti:master

Conversation

@JonasNicoletti
Copy link
Copy Markdown

No description provided.

JonasNicoletti and others added 3 commits November 1, 2020 10:28
@kevinskyba
Copy link
Copy Markdown
Owner

I've fixed the formatting a little and added the BaseModel's logic for parsing the JSON. The advantage of this is that this basically adds all attributes to the model by just changing the objects __dict__ object, but we also add custom mappings for our defined names and possible transformings (for dates or child objects).

I'm not sure if PlayerStats is the right naming here. PlayerStats should be a child object of an object called LeaguePlayer I think?!

@JonasNicoletti
Copy link
Copy Markdown
Author

About the name I took it from here https://github.com/kevinskyba/kickbase-api-doc/blob/25ba93dd21ff5219161ef6fdf8a386cefc0b0608/Kickbase.postman_collection.json#L351 but if you have one that fits better I can rename it, no problem with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants