WIP: Added support for biometrics (Touch ID/Face ID)#107
Open
alexw23 wants to merge 5 commits intokeybase:masterfrom
Open
WIP: Added support for biometrics (Touch ID/Face ID)#107alexw23 wants to merge 5 commits intokeybase:masterfrom
alexw23 wants to merge 5 commits intokeybase:masterfrom
Conversation
|
Why this PR is not approved or reviewed? |
|
I think there still is big interest in this... Why is it stale? 😞 |
|
Any update on this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First draft at tested and working TouchID support.
Still need to write unit tests and add some more config options for SetAccessControl (i.e
kSecAttrAccessibleWhenUnlockedThisDeviceOnly) is currently hard coded. Ideally this should just reference the value from SetAccessible (if any).Also getting the following error which is hard to fix right now. Any ideas would be great.
Currently the only way to use this is within a MacOS app (with developer ID, code sign etc). It's beyond the scope of this project as it would more so be the consumers of this project that would be using it. Once I add a PR for aws-vault I will come back and link to those instructions.