-
-
Notifications
You must be signed in to change notification settings - Fork 7
feat: polish the contributors page and consolidate #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Split bios into separate pages * Put all contributors onto same page with better formatting * Add links to contributors on main page and menus Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
darcywong00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of good polish!
| * [Get involved](../get-involved) | ||
| ## Core Keyman team | ||
|
|
||
| The core Keyman team is a small group of dedicated software developers, working |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can disambiguate "core Keyman" (team) from "Keyman core" (product) 🤔
main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I was trying to find a good disambiguation, but Main Keyman Team sounds a little boring compared to Core Keyman Team... I think it's not really going to be a big issue as only a few people care about Keyman Core itself.
| ## Navigation | ||
|
|
||
| * [About the Keyman team](../developers) | ||
| * About the Keyman team (this page) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove this line?
about/team/bios/darcywong00.md
Outdated
| My wife and I have two children. I also enjoy playing Ultimate (frisbee), going | ||
| to the gym, and playing boardgames. | ||
|
|
||
| * [About the Keyman team](../../team) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we just go up 1 level (for all the pages below)?
| * [About the Keyman team](../../team) | |
| * [About the Keyman team](../) |
Co-authored-by: Darcy Wong <darcy_wong@sil.org>
|
@darcywong00 all review comments addressed |
darcywong00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Test-bot: skip
Main page shows:
Team page shows: