-
-
Notifications
You must be signed in to change notification settings - Fork 7
feat: additional contributors #650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Adds about 20 further contributors who don't show up on GitHub, and split out former team members from the 'major contributors'. There are still many more contributors, but this is a reasonable first pass. Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
darcywong00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the rate this is growing, it'll soon become about.keyman.com 😄
|
|
||
|  | ||
|
|
||
| ### Support and Test Engineer (former) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and keyboard author?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nyny was also a keyboard author but primary roles were support/test
|
|
||
| I enjoy audax, other non-speedy cycling, and board games. | ||
|
|
||
| Daniel helped release the first version of Keyman for Linux. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markus' bio has it in quotes
| Daniel helped release the first version of Keyman for Linux. | |
| Daniel helped release the first version of "Keyman for Linux". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah nah I actually prefer it without quotes but I left it to each team member to write their bio
|
|
||
| </div> | ||
|
|
||
| <div markdown="1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts about splitting the KAB team into a separate section between "Core Keyman team" and "Major contributors"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wondered about this but didn't want to add yet another section at this point
| { "level": "core-previous", "name": "Nguonnyny Tan", "handle": "Nnyny", "title": "Support and Test Engineer" }, | ||
| { "level": "core-previous", "name": "Makara Sok", "handle": "MakaraSok", "title": "Support and Test Engineer" }, | ||
| { "level": "core-previous", "name": "Tom Bogle", "handle": "tombogle", "title": "Developer - macOS" }, | ||
| { "level": "core-previous", "name": "Daniel Glassey", "handle": "glasseyes", "title": "Developer - Linux" }, | ||
| { "level": "core-previous", "name": "Bharanidharan Jawehar", "handle": "bharanidharanj", "title": "Test Engineer" }, | ||
| { "level": "core-previous", "name": "Dinakaran Rajasekar", "handle": "dinakaranr", "title": "Test Engineer" }, | ||
| { "level": "core-previous", "name": "Serkan Kurt", "handle": "SerkanKurt", "title": "Developer - Android, iOS, macOS" }, | ||
| { "level": "core-previous", "name": "Gabriel Wong", "handle": "gabrielwong", "title": "Developer - iOS" }, | ||
| { "level": "core-previous", "name": "Eddie Antonio Santos", "handle": "eddieantonio", "title": "Developer - predictive text" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the titles "(former)"?
And is the intent to eventually embed the title fields in the bio pages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, the "title" info under the avatars is missing for most of the core members. They are on these bios:
- mcdurdin
- jahorton
- Markus-SWAG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the titles "(former)"?
They are in the "former" section, so no need
And is the intent to eventually embed the title fields in the bio pages?
Not really worth the engineering effort I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, gotcha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now https://keyman.com/about/team?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes could do, doesn't really matter though, does it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l 17
I thought this PR is moving away from generating about/contributors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it generates keyman.com/about/team, true, ok will fix
darcywong00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm



Adds about 20 further contributors who don't show up on GitHub, and split out former team members from the 'major contributors'. There are still many more contributors, but this is a reasonable first pass.
Also adds Markus's bio and fix typo in EB's name!
Test-bot: skip