Add Session type parameter for TypeInfo, Lists and Context - #8570
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
dcousens
commented
May 11, 2023
| * | ||
| * @default keystonejs-session | ||
| */ | ||
| cookieName?: string; |
Member
Author
There was a problem hiding this comment.
I added this, as keystonejs-session as a cookie name was wildly opinionated
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
dcousens
changed the title
dcousens
force-pushed
the
custom-redis
branch
5 times, most recently
from
May 15, 2023 04:15
ec152ca to
5f8188c
Compare
dcousens
changed the title
Session type parameter for TypeInfo, Lists and Context
dcousens
force-pushed
the
custom-redis
branch
6 times, most recently
from
May 18, 2023 02:20
c036694 to
50271fd
Compare
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request amends the types exported by Keystone to support a new
Sessiontype parameter forTypeInfo, written asTypeInfo<Session>.The following type parameters have been added:
TypeInfo<Session>Lists<Session>Context<Session>Config<Session>The new
Sessiontype parameter will propagate to the underlying functions and schema in the same manner asContext, ensuring thatcontext.sessionis changed from the default ofany.This pull request additionally adds or fixes a number of session related examples to adhere to this new format, and actually resolved a few type errors that had existed with respect to the previous
Sessiontypes used in the examples. 🎉