Conversation
Signed-off-by: Jenny Shu <jenny.shu@solo.io>
|
LGTM According to official docs, this leaves the v2.2.x release branch with the same code owners as before, only changing |
I spoke too soon. I was thinking about CODEOWNERS files on release branches like kgateway-dev/kgateway v2.2.x and wondering if this would adversely affect them or not. Let me look more deeply at how github handles this file. |
I think removing the group will cause the v2.2.x branch to reference a nonexisting group, which probably means that no one has to sign off on agentgateway API changes for 2.2.x. What if you first land a CODEOWNERS change to every LTS branch that replaces or removes those API owners? |
|
yeah good catch. I think we can remove the codeowners from the lts branches (at least for agw), let me open a PR for that |
|
have kgateway-dev/kgateway#13532 open, but need to fix CI |
agentgateway-api-owners, as the agentgateway code has been split out into a separate repo