Skip to content

update codeowners#150

Merged
jenshu merged 2 commits intokgateway-dev:mainfrom
jenshu:update-codeowners
Feb 17, 2026
Merged

update codeowners#150
jenshu merged 2 commits intokgateway-dev:mainfrom
jenshu:update-codeowners

Conversation

@jenshu
Copy link
Copy Markdown
Contributor

@jenshu jenshu commented Feb 17, 2026

  • remove agentgateway-api-owners, as the agentgateway code has been split out into a separate repo
  • add @andy-fong and @davidjumani as a kgateway api codeowners

Signed-off-by: Jenny Shu <jenny.shu@solo.io>
@jenshu jenshu added the do-not-merge/hold The PR should not be merged yet label Feb 17, 2026
Signed-off-by: Jenny Shu <jenny.shu@solo.io>
@jenshu jenshu removed the do-not-merge/hold The PR should not be merged yet label Feb 17, 2026
@chandler-solo
Copy link
Copy Markdown
Contributor

LGTM

According to official docs, this leaves the v2.2.x release branch with the same code owners as before, only changing main and thus future release branches.

@chandler-solo
Copy link
Copy Markdown
Contributor

LGTM

According to official docs, this leaves the v2.2.x release branch with the same code owners as before, only changing main and thus future release branches.

I spoke too soon. I was thinking about CODEOWNERS files on release branches like kgateway-dev/kgateway v2.2.x and wondering if this would adversely affect them or not. Let me look more deeply at how github handles this file.

@chandler-solo
Copy link
Copy Markdown
Contributor

LGTM
According to official docs, this leaves the v2.2.x release branch with the same code owners as before, only changing main and thus future release branches.

I spoke too soon. I was thinking about CODEOWNERS files on release branches like kgateway-dev/kgateway v2.2.x and wondering if this would adversely affect them or not. Let me look more deeply at how github handles this file.

I think removing the group will cause the v2.2.x branch to reference a nonexisting group, which probably means that no one has to sign off on agentgateway API changes for 2.2.x. What if you first land a CODEOWNERS change to every LTS branch that replaces or removes those API owners?

@jenshu
Copy link
Copy Markdown
Contributor Author

jenshu commented Feb 17, 2026

yeah good catch. I think we can remove the codeowners from the lts branches (at least for agw), let me open a PR for that

@jenshu jenshu added the do-not-merge/work-in-progress The PR is still being worked on label Feb 17, 2026
@jenshu
Copy link
Copy Markdown
Contributor Author

jenshu commented Feb 17, 2026

have kgateway-dev/kgateway#13532 open, but need to fix CI
edit: merged

@jenshu jenshu removed the do-not-merge/work-in-progress The PR is still being worked on label Feb 17, 2026
@jenshu jenshu merged commit 73aa3b0 into kgateway-dev:main Feb 17, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants